npezza93 / archipelago

A minimalist open-source terminal emulator built on web technology
MIT License
51 stars 8 forks source link

An in-range update of xterm is breaking the build 🚨 #145

Closed greenkeeper[bot] closed 5 years ago

greenkeeper[bot] commented 5 years ago

The dependency xterm was updated from 3.12.2 to 3.13.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

xterm is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ❌ **continuous-integration/appveyor/branch:** AppVeyor build failed ([Details](https://ci.appveyor.com/project/npezza93/archipelago/builds/24429695)). - ❌ **continuous-integration/travis-ci/push:** The Travis CI build failed ([Details](https://travis-ci.org/npezza93/archipelago/builds/530378508?utm_source=github_status&utm_medium=notification)).

Release Notes for 3.13.0

πŸš€ Features

πŸ“¦ API

  • A new and improved event API has been introduced that properly types the arguments within the listener (#2008) via @Tyriar
    Screen Shot 2019-05-08 at 7 03 49 PM
  • The new windowsMode option replaces the old winptyCompat addon (#1978, #1985, #1993) via @Tyriar, note that there are no longer the previous protections in place to prevent the mode from running on non-Windows operating systems.
  • Terminal.markers is now a ReadonlyArray (previously []) (#2036) via @Tyriar

🐞 Bug fixes

  • Prevent unhandled sequence code from being hit incorrectly (#1923) via @jerch
  • Fix UTF-8 mouse coordinate support (#1952) via @NickShaffner
  • Don't open links when selecting text and releasing the mouse in the middle of the link (#1958) via @nikonso
  • Don't do a full refresh when no needed after pausing and resuming rendering (#1976) via @Tyriar
  • No longer scroll to the xterm.js text area when it's focused (#1982) via @Tyriar
  • Fix the CSI scroll down handler (#1995) via @thekondr
  • Properly send the ^_ sequence (emacs undo) (#2052) via @jflatow
  • search addon
    • Fix skipping wrapped line results after resizing the terminal (#1866) via @ntchjb
    • Fix find next/previous not selecting correct text after resizing the terminal (#2025) @thebradbain
  • webLinks addon

πŸ“ Documentation and internal improvements

  • Open the browser automatically when the server is ready when debugging (#1968) via @nikonso
  • Tweak rtty messaging (#1973) via @zhaojh329
  • Recommend 127.0.0.1 over 0.0.0.0 on Linux and macOS to simplify documentation (#1987) via @Tyriar
  • Fix backspace in the demo (#1997) via @Tyriar
  • Better integration with VS Code
    • Add setting for VS Code that tells TypeScript to use single quotes (#2009) via @Tyriar
    • Add build and test VS Code tasks (#2032) via @Tyriar
    • Add dev container support (#2040) via @Tyriar
  • Improving project structure
    • Build using TypeScript project references (#1984) via @Tyriar
    • Ensure DOM APIs are not used within the common and core sub-projects (#1992) via @Tyriar
    • Create a "ui" TypeScript sub-project (#2026) via @Tyriar
  • Releases

πŸ›‘ Breaking changes

  • The winptyCompat addon has been moved into core and is now enabled via the windowsMode option:
    // before 3.13.0
    import winptyCompat = require('vscode-xterm/lib/addons/winptyCompat/winptyCompat');
    Terminal.applyAddon(winptyCompat); 
    const term = new Terminal();
    
    // after 3.13.0
    const term = new Terminal({ windowsMode: true });
    See the API section for more information.

⚠️ Deprecations

  • The on, off, emit and addDisposableListener APIs are now deprecated and are planned to be removed in v4.0.0 (#2008) via @Tyriar, they are replaced with the new "explicit event API".
    // deprecated
    term.on('resize', e => doSomething(e));
    
    // recommended
    term.onResize(e => doSomething(e));
    We took this opportunity to slim down the events, cutting out some that thought are no longer needed. If you are using any events that were not carried over to the new event API please create an issue and let us know how you're using it to see if we should expose it.

πŸŽ‰ New real-world use cases


A special thanks to @Eugeny of the Terminus project for trialing the beta release and helping catch some nasty bugs before we released ❀️

Commits

The new version differs by 271 commits ahead by 271, behind by 6.

  • ffc868a Merge pull request #2055 from xtermjs/Tyriar-patch-2
  • e40f924 v3.13.0
  • ca1c647 Merge pull request #2054 from Tyriar/fix_beta_cd
  • 79e182d Actually fix beta CD
  • c1b5672 Merge pull request #2052 from jflatow/unit-separator
  • dc236ae Send the unit separator for C-_, like some other keyboards
  • 2d0937a Merge pull request #2047 from Tyriar/2044_cd_fix
  • 0d5cd95 Base the next beta version on the correct current beta
  • 4729bfa Merge pull request #2043 from cubiclesoft/add_php_app_server
  • a88469a Added PHP App Server to Real-world uses section.
  • d6da010 Merge pull request #2035 from jerch/2028_handle_joined_cells
  • c6138ed Merge branch 'master' into 2028_handle_joined_cells
  • 15a6c98 Merge pull request #2040 from Tyriar/devcontainer
  • ca193ed Merge branch 'master' into 2028_handle_joined_cells
  • ffcdba8 simplify JoinedCellData

There are 250 commits in total.

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 5 years ago

After pinning to 3.12.2 your tests are passing again. Downgrade this dependency πŸ“Œ.