search

npgsql / efcore.pg

Entity Framework Core provider for PostgreSQL
PostgreSQL License
1.54k stars 226 forks source link

Postgis types: Geography vs Geometry #247

Closed davidglassborow closed 7 years ago

davidglassborow commented 7 years ago

Hi, I'm just looking at adding some GIS functionality to my app, and weighting up geometry vs geography in PostGIS (e.g. https://gis.stackexchange.com/questions/26082/what-is-the-difference-between-geometric-and-geographic-columns#26092).

Npg supports geometry, but not geography. Is there a technical reason for this or because geography is relatively new ? Would you be open to someone adding geography support, and with knowledge of the internals, would that be relatively straight forward do you think ?

Thanks for all your great work on Npg.

roji commented 7 years ago

Thanks for your interest... there's no specific reason that geography isn't implemented in Npgsql - it's just been a question of time and developer interest. I'd definitely welcome a PR that adds support, and it shouldn't be very difficult to implement. Am going to close this issue as a duplicate of #1322, which also requested geography support.

Note that a PR is open, adding support for 3D PostGIS geometry types (this is not the same as geography). If anyone is considering working on geography support, it's best to be careful not to conflict with that work (ideally starting work after it is merged).

davidglassborow commented 7 years ago

Just realised I raised this in the wrong repo.