search

npm-dom / dom-event

Add/remove DOM events
http://npm.im/dom-event
34 stars 7 forks source link

consider removing from npm-dom #2

Closed necolas closed 9 years ago

necolas commented 10 years ago

this module appears to be intending to account for IE's event model, but it doesn't normalize the event object or account for IE quirks like lack of DOMContentLoaded. i've been through these issues with the original component packages when building the front-end for twitter's cards :).

i'd suggest the npm-dom modules support IE 9+ and recommend the use of shims for those who need IE 8. for example, a fairly complete event shim is https://github.com/jonathantneal/EventListener)

azer commented 10 years ago

hmm, why do we need DOMContentLoaded for adding events ? I guess there is a bug that I don't know yet

necolas commented 10 years ago

it's that DOMContentLoaded is missing in IE 8 and needs some special treatment if someone tries to listen to it: https://github.com/necolas/event-shim.js/blob/master/event-shim.js#L144-L145. but there are various other significant differences between the event models that makes a shim worthwhile for those who need to support IE 8.

azer commented 10 years ago

I see, but it worked for me for years actually, I guess because my usage is just limited with adding functions / removing functions. For example, I built a chess game using something almost same with this library, and people still play it with old browsers unfortunately. bunch of public universities in Turkey have computers with frozen software = Windows XP + IE6. It's awful but things don't change easily in public universities, and so it's good to support those have access from there as we can even it's not perfect...

necolas commented 9 years ago

i don't understand. this doesn't work properly in IE8; better to remove the code intended for IE8 and say this in an IE9+ module, and tell people to use a proper, working event shim for IE8 if they need.