reggi
commented
4 months ago resolved-import issue
Run npm test --ignore-scripts
> abbrev@2.0.0 test
> tap
file:///home/runner/work/abbrev-js/abbrev-js/node_modules/resolve-import/dist/esm/resolve-import.js:6
import { isBuiltin } from 'module';
^^^^^^^^^
SyntaxError: The requested module 'module' does not provide an export named 'isBuiltin'
at ModuleJob._instantiate (internal/modules/esm/module_job.js:10[4](https://github.com/npm/abbrev-js/actions/runs/9260124177/job/25473317472?pr=84#step:8:5):21)
at async ModuleJob.run (internal/modules/esm/module_job.js:149:[5](https://github.com/npm/abbrev-js/actions/runs/9260124177/job/25473317472?pr=84#step:8:6))
at async Loader.import (internal/modules/esm/loader.js:177:24)
at async Object.loadESM (internal/process/esm_loader.js:[6](https://github.com/npm/abbrev-js/actions/runs/9260124177/job/25473317472?pr=84#step:8:7)8:5)
Error: Process completed with exit code 1.https://www.npmjs.com/package/resolve-import
Doesn't support 14 anymore because the use of:
module.isBuiltin(moduleName)# Added in: v18.6.0, v16.17.0
https://nodejs.org/api/module.html#moduleisbuiltinmodulename
also specified in engines https://github.com/isaacs/resolve-import/blob/main/package.json#L148-L150
nyc-arg issue
Run npm test --ignore-scripts
> abbrev@2.0.0 test
> tap
/home/runner/work/abbrev-js/abbrev-js/node_modules/jackspeak/src/index.ts:922
throw new Error(`Unknown config option: ${field}`, {
^
Error: Unknown config option: nyc-arg
at Jack.validate (/home/runner/work/abbrev-js/abbrev-js/node_modules/jackspeak/src/index.ts:922:15)
at Jack.setConfigValues (/home/runner/work/abbrev-js/abbrev-js/node_modules/jackspeak/src/index.ts:688:12)
at TapConfig.extendConfigData (/home/runner/work/abbrev-js/abbrev-js/node_modules/@tapjs/config/src/index.ts:380:19)
at TapConfig.loadConfigData (/home/runner/work/abbrev-js/abbrev-js/node_modules/@tapjs/config/src/index.ts:327:18)
at TapConfig.loadConfigFile (/home/runner/work/abbrev-js/abbrev-js/node_modules/@tapjs/config/src/index.ts:[4](https://github.com/npm/abbrev-js/actions/runs/9260124177/job/25473318528?pr=84#step:8:5)22:21)
at Function.load (/home/runner/work/abbrev-js/abbrev-js/node_modules/@tapjs/config/src/index.ts:[5](https://github.com/npm/abbrev-js/actions/runs/9260124177/job/25473318528?pr=84#step:8:6)41:15)
at <anonymous> (/home/runner/work/abbrev-js/abbrev-js/node_modules/@tapjs/run/src/main-config.ts:[7](https://github.com/npm/abbrev-js/actions/runs/9260124177/job/25473318528?pr=84#step:8:8):37) {
extendedFrom: [ '/home/runner/work/abbrev-js/abbrev-js/package.json' ],
[cause]: {
found: 'nyc-arg',
path: '/home/runner/work/abbrev-js/abbrev-js/package.json'
}
}no mention of removing the arg in https://node-tap.org/changelog/
one commit i found here where they change the package key to just nyc https://github.com/tapjs/tapjs/commit/0799730e3f1e65584e502fa500e4d59aadc04615
update:
npx impose https://reggi.github.io/modernize-tap.json -y
npm i && npm run template-oss-apply however this doesn't work because it doesn't fix the nyc-args issue, tap switched to just using top-level nyc which is a completely different syntax not using flags.
wraithgar
dependabot[bot]
Bumps tap from 16.3.10 to 19.0.2.
Release notes
Sourced from tap's releases.
... (truncated)
Commits
d55bb8eupdate versionsd342477c8@9.1.0e49b6dbupdate versionsdba5bf8Update ts-node fork for@tsconfig/node20f6d065cRemove duplicate sentence in create-plugin readme6a30ea6@isaacs/ts-node-temp-fork-for-pr-2009@10.9.6f1e729bremove prepare script that is breaking CIf3f99d8update versions1482592jackspeak@3.1.2, glob@10.3.16df3bc60asserts: allow matching errors on the errors arrayMost Recent Ignore Conditions Applied to This Pull Request
| Dependency Name | Ignore Conditions | | --- | --- | | tap | [>= 18.a, < 19] |Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show