npm / cli

the package manager for JavaScript
https://docs.npmjs.com/cli/
Other
8.09k stars 2.92k forks source link

fix: add first param titles to logs where missing #7533

Closed lukekarrys closed 2 weeks ago

lukekarrys commented 2 weeks ago

The first argument to all log.method() calls gets formatted differently with a color. So calls to these should always be a short descriptive title or an empty string.

npm-cli-bot commented 2 weeks ago

found 1 benchmarks with statistically significant performance regressions

app-large clean lock-only cache-only modules-only no-lock no-cache no-modules no-clean show-version run-script cache-only
peer-deps
no-clean
audit
npm@latest 34.127 ±0.97 11.022 ±0.43 12.259 ±0.12 1.621 ±0.01 1.590 ±0.03 1.320 ±0.00 8.325 ±0.13 1.285 ±0.01 0.138 ±0.00 0.165 ±0.00 13.905 ±0.06 3.549 ±2.11
#7533 33.327 ±0.98 10.852 ±0.03 12.110 ±0.14 1.640 ±0.03 1.594 ±0.00 1.319 ±0.00 8.444 ±0.12 1.332 ±0.02 0.143 ±0.00 0.169 ±0.00 15.653 ±0.42 2.186 ±0.01
app-medium clean lock-only cache-only modules-only no-lock no-cache no-modules no-clean show-version run-script cache-only
peer-deps
no-clean
audit
npm@latest 26.306 ±1.20 7.959 ±0.00 8.931 ±0.04 1.548 ±0.03 1.534 ±0.03 1.428 ±0.01 5.858 ±0.03 1.360 ±0.01 0.141 ±0.00 0.171 ±0.00 9.784 ±0.17 3.122 ±1.66
#7533 26.914 ±0.57 8.284 ±0.04 9.276 ±0.05 1.587 ±0.01 1.542 ±0.02 1.487 ±0.07 6.046 ±0.03 1.315 ±0.01 0.139 ±0.00 0.167 ±0.00 10.290 ±0.38 2.089 ±0.13