search

npm / cmd-shim

The cmd-shim used in npm
ISC License
76 stars 40 forks source link

actually depend on graceful-fs #7

Closed isaacs closed 10 years ago

isaacs commented 10 years ago

Since graceful-fs doesn't monkey-patch the builtin, there's no need to make it optional. Also, it's currently being pulled in all the time anyway, so why not just depend on it normally?

ForbesLindesay commented 10 years ago

We'll have to remove node@0.8 from the .travis.yml file, but this seems cleaner and simpler than #9 to me. P.S. I've added @isaacs and @othiym23 as collaborators on this repo in case I fail to respond to things quickly enough.

Also, I don't really know enough to know whether #4 should be merged or not.

isaacs commented 10 years ago

Does graceful-fs not work on v0.8?

isaacs commented 10 years ago

Oh, ffs, ok, make it ~ or whatever.

ForbesLindesay commented 10 years ago

Yes, that might be sufficient

isaacs commented 10 years ago

Expanded the graceful-fs dep version range, so it should work wiht v0.8 now.

ForbesLindesay commented 10 years ago

That looks like it should be fine, but the travis-ci build is failing for 0.8?

isaacs commented 10 years ago

OMG. npm 1.2 is so ancient and buggy and terrible.

@tjfontaine Please accept https://github.com/joyent/node/pull/7797 this is a huge waste of time for all of us.

@ForbesLindesay updated, should work now. Let's wait for travis to complete.

isaacs commented 10 years ago

Travis completed successfully. +1.

ForbesLindesay commented 10 years ago

Released as 2.0.1