[BUG] [ReOpening] Having a file named node.js will be "run" instead of node

[ckohen]

Is there an existing issue for this?

• [X] I have searched the existing issues

The existing issue was closed with the reason JS shouldn't be in your pathext environment variable. While that is a solution, it is a completely invalid solution from my perspective. It took me 2 hours of debugging to identify that was the problem, and in case you were unaware, that is the default in Windows. Though it certainly seems like you are aware given you attempt to remove it in the shim. Now that I know what it is, its an easy fix, but that's a terrible developer experience and needs fixing.

Current Behavior

• As described in #40 the node.js file will be "run" by the OS instead of running the node executable located somewhere in path
• After inspecting the output shim, it appears there was an attempt to fix this, but it does not work.

For reference, npms generated shim for rimraf:

@ECHO off
GOTO start
:find_dp0
SET dp0=%~dp0
EXIT /b
:start
SETLOCAL
CALL :find_dp0

IF EXIST "%dp0%\node.exe" (
  SET "_prog=%dp0%\node.exe"
) ELSE (
  SET "_prog=node"
  SET PATHEXT=%PATHEXT:;.JS;=;%
)

endLocal & goto #_undefined_# 2>NUL || title %COMSPEC% & "%_prog%"  "%dp0%\..\rimraf\bin.js" %*

Expected Behavior

• Running whatever bin js file is supposed to run as it does when yarn correctly generates this shim.

For reference, yarns generated shim for rimraf:

@IF EXIST "%~dp0\node.exe" (
  "%~dp0\node.exe"  "%~dp0\..\rimraf\bin.js" %*
) ELSE (
  @SETLOCAL
  @SET PATHEXT=%PATHEXT:;.JS;=;%
  node  "%~dp0\..\rimraf\bin.js" %*
)

Steps To Reproduce

1. npm install a package with a bin script
2. create a file called node.js in the same directory as the package.json you will be running scripts from OR the directory you run the command directly from
3. run the script via a script in package.json OR with npx
4. notice the file opens and the script never runs

Environment

• npm: 8.16.0
• Node: 16.15.1
• OS: Windows 10 Home 21H2 (19044.1826)
• platform: Desktop