search

npm / fstream

Advanced FS Streaming for Node
ISC License
208 stars 43 forks source link

standard #39

Closed feross closed 9 years ago

feross commented 9 years ago

standard got a bit stricter. Here's a PR to fix up fstream for you.

I expect that standard will not change very much going forward, so this type of tweaking shouldn't be necessary in the future. I also added this repo to our test suite so we don't accidentally make a rule stricter in the future.

Peace :+1:

feross commented 9 years ago

Tests fail due to a bug in fstream's package.json, see: https://github.com/npm/fstream/commit/ad2be6e8a208c9121227a10154a458255891df57#commitcomment-9812501

othiym23 commented 9 years ago

Landed in 58e0fea373ffc2a8dfa9c917ee51e5616d04124d and 6e78ceeee08950bfa358fe2ae3f5801608d0b963, to bring it all the way up to standard@3 compliance. (I'll upgrade the dependency when standard@3 is non-alpha/-beta. Thanks, Feross!

feross commented 9 years ago

:+1: