search

npm / fstream

Advanced FS Streaming for Node
ISC License
208 stars 43 forks source link

Fix treatment of long file paths in Windows #42

Open avital opened 9 years ago

avital commented 9 years ago

3e5d171 (from November 2011) introduced code to fix treatment of long file paths in Windows. Then, one week later, this commit fixed long file paths directly in Node's fs library: joyent/node@1f16a7b

So, the code currently in fstream actually /breaks/ long file paths in Windows.

This fixes it, but keeps an additional mysterious line introduced by that original commit that I don't understand.

I also added an automated test for this, and also guarded the existing symlink test to not run on Windows... It would be nice if the test suite were set up to automatically run on Windows as well.

Fixes #30. Thanks to @sdarnell for identifying the problem.

othiym23 commented 9 years ago

I have some comments on this, and I'd like to get the eyes of somebody who has a better grasp of Node's history with UNC paths to take a look at this (@piscisaureus, is this something you could take a look at, or do you know who we could ask to take a look at it?). This is a more or less invisible piece of npm's infrastructure, so touching it is a little nervewracking for me, but if there's code in here that complicates filesystem handling on Windows, it would be good to get rid of it.