review badge processing

npm / marky-markdown

npm's markdown parser

https://www.npmjs.com/package/@npmcorp/marky-markdown

405 stars 72 forks source link

review badge processing #258

Open ashleygwilliams opened 7 years ago

ashleygwilliams commented 7 years ago

from a quick read there are few things that concern me about how we process badges:

we add classes that GitHub doesn't add
we statically list a set of origins that is definitely not complete and we haven't updated in a while

given the product direction of parity with GitHub, and a desire for improved performance, i'd like to revisit this code and remove unnecessary processing. thoughts?

ashleygwilliams commented 7 years ago

relevant code:

impl https://github.com/npm/marky-markdown/blob/0302f9f515248a86153f67ba26d48729a87ff45e/lib/badges.js
tests https://github.com/npm/marky-markdown/blob/0302f9f515248a86153f67ba26d48729a87ff45e/test/badges.js

wooorm commented 7 years ago

Maybe of use: https://github.com/wooorm/is-badge (can also be used in GH-251).

revin commented 7 years ago

oh awesome, thanks @wooorm that looks perfect 👍