search

npm / marky-markdown

npm's markdown parser
https://www.npmjs.com/package/@npmcorp/marky-markdown
405 stars 71 forks source link

use markdown-it-github-headings instead of internal heading-links.js #359

Open Flet opened 7 years ago

Flet commented 7 years ago

Hello!

I extracted the code in heading-links.js into its own standalone markdown-it plugin (with some light modification). This was done so this excellent code could be used in another project.

Here is the repo: https://github.com/Flet/markdown-it-github-headings

Is there any interest in switching to this new plugin in marky-markdown? I'm happy to give folks full access to the repo (or transfer it) if that helps. All the defaults have been set to match the current behavior of marky-markdown.

revin commented 7 years ago

oh, cool, that seems like a useful standalone package to me. I'm into it (having access would be nice, but probably not a 100% blocker or anything; that stuff doesn't change all that much really). But of course, @ashleygwilliams is the boss 'round these parts, so I'd say, 👍 , but she has the final say.

revin commented 7 years ago

Hey @Flet, seems the folks are busy, so perhaps I get to make the call myself 😛

This sounds good to me; would you be willing to create a PR here that implements this?

Also, assuming you're still willing, I'd definitely like to take you up on your offer of giving us full access to the repo Just In Case™ 🎉 🌮 🎉

Flet commented 7 years ago

Sure thing @revin!