npm / marky-markdown

npm's markdown parser
https://www.npmjs.com/package/@npmcorp/marky-markdown
405 stars 71 forks source link

Images with titles wrapped in parentheses are no longer rendering correctly on npmjs.com #384

Closed simov closed 7 years ago

simov commented 7 years ago
[![npm-version]][npm]
![1]

  [1]: http://i.imgur.com/rKYxW.jpg (Oh Hi)
  [npm-version]: https://img.shields.io/npm/v/slack-command-hackernews.svg?style=flat-square (NPM Package Version)
  [npm]: https://www.npmjs.com/package/slack-command-hackernews

npm-version 1

I have been using this syntax since forever:

  [0]: url (title)
  [named]: url (title)

The other day I published a new module and it doesn't work any more
This is the markdown, just tested with 10.1.2 locally.

It works with quoted titles:

  [1]: url "title"
  [named]: url "title"

But I have lots of modules using the parentheses syntax already and probably I'm not alone.

revin commented 7 years ago

Hi @simov, thanks for reporting! This is definitely a bug with link/image parsing; we'll get it fixed.

simov commented 7 years ago

Thanks!

revin commented 7 years ago

OK, merged a PR for it, and published marky 10.1.3. Getting it live on the site will depend on how busy the npm folks are 😛

revin commented 7 years ago

PS: I put marky 10.1.3 in my live marky tester and it renders your README as expected 🎉 🎉 🎉

simov commented 7 years ago

Nice! Thanks for the link :+1:

simov commented 7 years ago

@revin how can I tell if the next release of the NPM's website is rolled out? I think the module's readme is generated on publish, so I'm not sure if it's ok to publish again.

revin commented 7 years ago

@bcoe would you mind pinging us here when 10.1.3 is rolled out?

revin commented 7 years ago

@simov ok, so two things:

1) 10.1.3 is live on the site, so you're good to go 2) To see the currently deployed version without publishing something yourself, go to the npm home page, choose something from the "recently updated packages" section, then view source on the package page, then search for "marky" and you'll see the debug comment indicating the version.

simov commented 7 years ago

Thanks for your support again, I appreciate it!

That's a good tip too, the funny thing was that I wasn't logged in so it took me awhile to figure out where that section was :)

:sparkles: