search

npm / marky-markdown

npm's markdown parser
https://www.npmjs.com/package/@npmcorp/marky-markdown
405 stars 72 forks source link

Phone Number Links Not Being Seen #427

Closed rwxrob closed 6 years ago

rwxrob commented 6 years ago

screen shot 2018-02-20 at 8 03 44 pm screen shot 2018-02-20 at 8 03 56 pm screen shot 2018-02-20 at 8 03 32 pm

rwxrob commented 6 years ago

By the way, pandoc gets this perfectly (and is just so much faster).

revin commented 6 years ago

@robmuh thanks for the issue! It looks like markdown-it (per the online demo) renders this ok, but github doesn't, at least in a gist. Do you have an example of a doc on github proper that renders this as you're expecting? If not, it would unfortunately be a non-goal of this project since the idea is to match github's output as closely as possible.

rwxrob commented 6 years ago

GitHub has several renders internally (which I found out in a similar thread). While I find the notion of matching a flawed markdown renderer a priority, um, interesting, I actually have already found a work around (pandoc). This was just a good faith effort to let you know. Your code does not comply to any markdown spec whatsoever while it contains this bug (which I have proved by using exactly the same markdown and having it work with pandoc, which is authored by the author and creator of the CommonMark spec). If you close it that is your choice and I understand the reasons even if I strongly disagree with them. Thanks for responding.

revin commented 6 years ago

We definitely appreciate all good faith efforts to let us know about things like this, but yes, the project's stated goal is to match GitHub's output even when it's not CommonMark (they've actually cleaned up a lot of things over time; tracking it all and matching quirks has been...interesting)—basically to be an open source JavaScript implementation of GitHub's observed renderer behavior. So this is an area where it's basically working as currently (sadly) intended 😛

rwxrob commented 6 years ago

Do you have a link to the actual project on GitHub where I can report this? I have tried other GitHub repos and had them tell me "submit a support request"

revin commented 6 years ago

Oh, great question. The only one I know of is https://github.com/github/cmark/, but I'm not sure if that's the one they use in production, or is just for GFM spec purposes.