search

npm / marky-markdown

npm's markdown parser
https://www.npmjs.com/package/@npmcorp/marky-markdown
405 stars 71 forks source link

#320 (relative image paths) seems to have regressed #437

Open Qix- opened 5 years ago

Qix- commented 5 years ago

320, which supposedly fixed relative image links, seems to have regressed. Apparently it's been like this for some time.

That, or the npm website isn't using marky correctly.

https://npmjs.org/package/chalk

image

Further, is there any reason why you're using using Regex to parse HTML?

M-jerez commented 1 year ago

There seem to be an issue when using the picture and source tags as well.

  <picture>
    <source media="(prefers-color-scheme: dark)" srcset="./assets/public/logo-dark.svg?raw=true">
    <source media="(prefers-color-scheme: light)" srcset="./assets/public/logo.svg?raw=true">
    <img alt='mion, a mikro kit for Typescript Serverless APIs' src='./assets/public/logo.svg?raw=true' width="403" height="150">
  </picture>

This is mostly done so image looks good both in npm and github as the later uses dark color scheme by default. Npm pacakge: https://www.npmjs.com/package/@mionkit/router Github repo: https://github.com/MionKit/mion/tree/master/packages/router