Infer module, description, and scripts.start from package.json

[zeke]

Things would be a bit more DRY in service.json if ndm would read from package.json in the absence of certain properties. Instead of this:

{
  "newww": {
    "module": "newww",
    "description": "A total rewrite of npm-www using hapijs",
    "scripts": {
      "start": "node server.js"
    },
    "env": {
      "PORT": "8081"
    },
    "args": {}
  },
  "newww2": {
    "module": "newww",
    "description": "A total rewrite of npm-www using hapijs",
    "scripts": {
      "start": "node server.js"
    },
    "env": {
      "PORT": "8082"
    },
    "args": {}
  },
  "newww3": {
    "module": "newww",
    "description": "A total rewrite of npm-www using hapijs",
    "scripts": {
      "start": "node server.js"
    },
    "env": {
      "PORT": "8083"
    },
    "args": {}
  },
  "newww4": {
    "module": "newww",
    "description": "A total rewrite of npm-www using hapijs",
    "scripts": {
      "start": "node server.js"
    },
    "env": {
      "PORT": "8084"
    },
    "args": {}
  }
}

I would prefer something like this:

{
  "newww": {
    "env": {
      "PORT": "8081",
      "NODE_ENV": "PRODUCTION"
    }
  },
  "newww2": {
    "env": {
      "PORT": "8082",
      "NODE_ENV": "PRODUCTION"
    }
  },
  "newww3": {
    "env": {
      "PORT": "8083",
      "NODE_ENV": "PRODUCTION"
    }
  },
  "newww4": {
    "env": {
      "PORT": "8084",
      "NODE_ENV": "PRODUCTION"
    }
  }
}

For personal reference, these spots in the code are related:

• https://github.com/npm/ndm/blob/master/test/service-test.js
• https://github.com/npm/ndm/blob/386cb6365d3a8b33a5dd653cf474db778dc52e2b/lib/service.js#L217
• https://github.com/npm/ndm/blob/386cb6365d3a8b33a5dd653cf474db778dc52e2b/lib/service.js#L271

[zeke]

PS This is related to https://github.com/npm/newww/pull/164

[bcoe]

I've implemented your suggestions in: https://github.com/npm/ndm/pull/85, really helps clean things up.