search

npm / npm-registry-client

http://npm.im/npm-registry-client
ISC License
264 stars 108 forks source link

Add SSL params to request #116

Closed promag closed 6 years ago

promag commented 9 years ago

This change adds the the option to define (mainly) SSL parameters in fetch/request. This allows, for instance, npm to use different SSL certificates per scope/registry.

There will be one HttpsAgent for each SSL configuration.

othiym23 commented 9 years ago

This patch will probably be superseded by an(other) archictectural rework to npm-registry-client that splits apart tarball fetching (npm-fetch?), the registry client (npm-registry-client), and the shared low-level fetching code (npm-request?) used by both of the previous two. That will allow us to have one registry client / fetcher per site being downloaded from, which will obviate the need to have so much per-request configuration. @zkat will be along to close this issue when we have enough of that specified so that you have a place to follow its progress. Thanks for helping to prompt us to get this work done, and thanks for your time!

ruimarinho commented 9 years ago

@othiym23 any chance of merging this before the architectural change is in place? I understand that the PR aligns well with what you have in mind in terms of the bigger scope, but it may take a lot of time until it is concretised. Until then, using SSL with private registries is grounded on workarounds.

zkat commented 6 years ago

This is no longer necessary, as make-fetch-happen now takes care of any agent-related needs.