search

npm / npm-registry-client

http://npm.im/npm-registry-client
ISC License
264 stars 108 forks source link

using clone because JSON.parse(JSON.stringify(...)) errors when given undefined #124

Closed antialias closed 6 years ago

antialias commented 8 years ago

bump

antialias commented 8 years ago

Need anything else from me on this before it can be reviewed?

antialias commented 8 years ago

bump

antialias commented 8 years ago

bump. What would you like me to do with this PR? Say the word and I'll stop bothering you guys about it.

antialias commented 8 years ago

bump @othiym23 @iarna

necccc commented 7 years ago

+1 This would just solve a weird issue for us right now, the root.maintainers field seems to undefined in some cases, and prevents publishing

antialias commented 7 years ago

bump @othiym23 @iarna

antialias commented 6 years ago

bump @othiym23 @iarna

zkat commented 6 years ago

ugh this has been sitting around forever. We really shouldn't leave things hanging for this long like this.

Unfortunately, I would not take this patch: I don't think it's necessary to drag in a whole new dependency, when you can easily guard in this case with var maint = root.maintainers && JSON.parse(JSON.stringify(root.maintainers))

So I'm gonna close this, but I'll take a patch for a version using the guard? That seems fine enough to me.

antialias commented 6 years ago

@zkat https://github.com/npm/npm-registry-client/pull/171