search

npm / npm-registry-client

http://npm.im/npm-registry-client
ISC License
264 stars 108 forks source link

Add basic authentication support for remote tarballs #127

Closed marcbachmann closed 6 years ago

marcbachmann commented 8 years ago

This adds support for urls like https://user:pass@example.com/module.tar.gz. Sorry that there are no tests. I failed in writing them because of some strange password encoding. lib/server.js somehow only decoded a segment of the password.

zkat commented 6 years ago

I'm closing this PR because npm-registry-client is no longer used for fetching dependencies. I'm not sure if pacote supports this kind of URL, off the top of my head, but it's worth testing with the latest npm@5 and see if you can use these URLs now. If not, feel free to send me a PR to pacote or its dependencies that handle these. Cheers!

marcbachmann commented 6 years ago

Oh yeah. I currently don't have a use case for this anymore as the whole setup got easier in the last few years. Thanks for your work. 👏