search

npm / npm-registry-client

http://npm.im/npm-registry-client
ISC License
264 stars 108 forks source link

Feature: Login (without automated account creation) #136

Closed finnp closed 7 years ago

finnp commented 8 years ago

Hey :)

I created a new method .login, that is similar to .adduser, but will not create a new account and also not need an email address for the auth. This is related to https://github.com/npm/npm/issues/8337 and would close #135.

I am now noticing though that the email is also used for alwaysAuth. So probably it would make sense to remove it there as well? Anyway maybe at least this PR can be somewhat helpful.

Love, Finn

zkat commented 7 years ago

Hi, @finnp!

Sorry it's taken so long to address this PR. Thank you for taking the time to do it. It's kinda funny that all it takes is not sending the email to get this to happen.

That said, we have an internal RFC that's gonna bubble up in priority soon that's going to completely overhaul the way we do login in the CLI, and I'm afraid this PR wouldn't have much of a lifespan in light of that, not to mention that it's not clear to me what the impact of this might be in third party registries, which is a frustrating reality to deal with sometimes.

As such, I'm going to close this, and encourage you to keep an eye out for when we have a public RFC in the main CLI repo for what login is gonna end up looking like for us.

Have a good one! And thanks for the time you took with this. 👍

uyarn commented 3 years ago

any progress?