search

npm / npm-registry-client

http://npm.im/npm-registry-client
ISC License
264 stars 108 forks source link

Fix adduser command option #147

Closed sisidovski closed 7 years ago

sisidovski commented 7 years ago

Hi

After this commit https://github.com/npm/npm-registry-client/commit/fc7b81be395bef9ff45d3929b8154b50f0015d21 , adduser command does not work in my environment. I'm using private npm registry. Inside lib/request.js, it looks checking the value existence of params.authed and adding authed param to option variable. Inside lib/adduser.js, it refers same object to send request. So last request gets error because options has already authed param (this request fails). I updated to copy this object.

iarna commented 7 years ago

Hey, I was curious how you ended up using the most recent version of npm-registry-client? It's not actually used by any version ofnpm itself.

Regardless, thanks for catching this! I'm bringing it in and doing a patch release now.

iarna commented 7 years ago

And it's merged and in v7.4.3, thank you again.

sisidovski commented 7 years ago

Thank you for your work! We use this module directly to automate npm publish and need to use this as Node API 😃