s/retrier/retry - Githubissues

npm / npm-registry-client

http://npm.im/npm-registry-client

ISC License

264 stars 108 forks source link

s/retrier/retry #59

Closed timoxley closed 10 years ago

timoxley commented 10 years ago

Anything but 'retrier' please. 3 out of 10.

Also, perhaps… PERHAPS consider making these http log-level? I know they're not explicitly http requests but they're pretty tightly coupled.

othiym23 commented 10 years ago

Anything but 'retrier' please. 3 out of 10.

How about 'attempt'? That's the name of the method it's in (now).

consider making these http log-level?

Hm... http is pretty lean right now. I think failure is worth logging at http, but not each attempt. What's your use case?

othiym23 commented 10 years ago

Changed retrier → attempt and tweaked the error message a little to eschew redundancy in 1a1f2fd11f138c41670cc4e5ac23bfb2917f8855. Does this bring the score up to 6, at least?