search

npm / npm-registry-client

http://npm.im/npm-registry-client
ISC License
264 stars 108 forks source link

Fixes npm#6861 #89

Closed disrvptor closed 9 years ago

disrvptor commented 9 years ago

Check that the error property of parsed is not an object, which may be a valid value

othiym23 commented 9 years ago

Would it be too much of an imposition to ask for a test here? I totally overlooked the possibility that the combination of request and fetchAll would lead to problems, and it seems like this would be something easy for somebody else to overlook in the future. If you don't have time to write a test, I'll write one, but it might take me a little while.

disrvptor commented 9 years ago

I'll see what I can pull together, but it probably won't be for a couple of days.

disrvptor commented 9 years ago

Added tests

othiym23 commented 9 years ago

Landed as cce8f3f37cb617f4cc09d6c2dab06b297e5f1c9e and 697653cf4c399a1aa4a135e0ee5a9e07f1e6fc93, with a few tweaks for style and clarity. Thanks! This will go into the next version of npm.