refactor: add `normalizePackageMan` helper

[antongolub]

What / Why

Aligns normalization logic with directories.bin

See also: https://github.com/npm/normalize-package-data/blob/main/lib/fixer.js#L105

  fixManField: function (data) {
    if (!data.man) {
      return
    }
    if (typeof data.man === 'string') {
      data.man = [data.man]
    }
  },

References

• continues https://github.com/npm/read-package-json/pull/177
• relates https://github.com/npm/package-json/pull/104

CC @wraithgar

[wraithgar]

Looks like the tests aren't passing in Windows because of the classic / vs \ problem.

ETA: Look for the lines in the bin normalization code like: binKey.replace(/\\|:/g, '/') for how we deal with that there.

[antongolub]

The changes are separated now:

• This PR brings directories.man normalization

• 104 fixes the path issue

[wraithgar]

This will need a rebase because of #104 landing

[antongolub]

ref.replace(/\\|:/g, '/') is a common snippet, so I separated it into a function. If necessary, I can add another pull request to replace all similar statements with the helper.

[wraithgar]

If necessary, I can add another pull request to replace all similar statements with the helper.

Please do. I can land this PR now instead of waiting on that.

[wraithgar]

I wonder how much overlap there truly is between the bin and man normalization. I see that the bin normalization removes entries that reference nonexistent files while man doesn't.

If there's a 1:1 overlap would it be possible to pass bin or man to a shared function? If there are even one or two things that don't overlap that may be more work than it's worth but for things like this sharing code definitely helps, as your PRs this week have shown.

[wraithgar]

Also another small note about process. You don't need to @ the cli team for these. We have a codeowners file set up which automatically notifies us that a PR needs review when it's made.

[wraithgar]

Ah fiddlesticks I merged w/ an invalid prefix. I'll have to edit main now so heads up.

[wraithgar]

ok @antongolub the main branch is done being rewritten, if you git fetch now a PR made won't collide w/ the edited history.