search

npm / registry-issue-archive

An archive of the old npm registry issue tracker
https://npm.community
249 stars 47 forks source link

Publish hooks no longer firing on private user scope #294

Closed Nicktho closed 6 years ago

Nicktho commented 6 years ago

Hello, I have set up a few hooks for a private user with the "scope" type. It appears that publish events stopped being triggered at exactly 3:00pm 16th March. Multiple publishes have been made since with no event fired.

Results from wombat ls:

 REDACTED │ scope      │ @REDACTED    │ https://REDACTED.com.au 
  triggered Mar 16, 2018 3:00 PM │ 200

I've redacted sensitive information that i'm happy to share with in a private channel. Last publish was within the hour.

soldair commented 6 years ago

this should be fixed now. thanks for the heads up and sorry for the error.

Nicktho commented 6 years ago

Thanks a lot for the fix and speedy response! Amazing!

Is there anything you can share on what caused the error? :)

Nicktho commented 6 years ago

@soldair Has the api for hooks changed recently? I'm struggling to find information, but it appears now on a publish i'm receiving a package:change event instead of a package:publish, package:change does not have the new version in change.version where as package:publish does.

I can't find any documentation about these responses so i'm not sure if this is the best place to post this.

soldair commented 6 years ago

@Nicktho it shouldn't have changed =) it may be that the object looks different now :thinking: when we have no previous version of the package to compare in the hooks system. as in the first hook ever for a package the event triggered is always "change".

ill take a look and see whats going on.

Nicktho commented 6 years ago

ah that makes sense, perhaps just the first hook is change and the following are publish

soldair commented 6 years ago

yeah if a bunch of changes piled up it might not look like just a publish anymore.

kbluescode commented 6 years ago

@soldair @Nicktho has this been officially resolved?

Nicktho commented 6 years ago

@kbluescode Seemed to be a one-off issue. I no longer work at company that manages this NPM account although at the time hooks resumed as normal.