search

npm / www

community space for the npm website
https://npm.community
69 stars 48 forks source link

Tabs on the page page don't use pushState. #385

Open chriseppstein opened 6 years ago

chriseppstein commented 6 years ago

Link to the page

Any package page. E.g. https://www.npmjs.com/package/npm

Logged in or logged out?

Logged out, but probably unrelated

Expected behavior

If I copy the url and send it to someone they should see the same page that I was looking at in the same state. Clicking on a tab should update the navigation to the tab's url. E.g. https://www.npmjs.com/package/npm?activeTab=versions

Actual behavior

The page changes state, but the url remains unchanged.

Steps to reproduce the problem

  1. Click one of the tabs: Dependencies, Dependents, Versions

Browser with version

Chrome Version 66.0.3359.117

Any error message?

Nah.