search

npm / www

community space for the npm website
https://npm.community
69 stars 48 forks source link

"repository" sidebar box is incorrect for BitBucket repos #425

Open revelt opened 6 years ago

revelt commented 6 years ago

screen shot 2018-06-05 at 07 44 09

Link to the page

Any package's page, sidebar

Logged in or logged out?

Does not matter

Expected behavior

BitBucket repos for example https://bitbucket.org/codsen/detergent that are published to npm https://www.npmjs.com/package/detergent should link to correct "Repository" URL.

Currently, github icon is misleading and URL is wrong (git+https://revelt@bitbucket.org/codsen/detergent.git as opposed to https://bitbucket.org/codsen/detergent for example).

Actual behavior

Non-github repos link to git URL, which is incorrect for BitBucket repos. Also, GitHub icon is wrongly shown.

Steps to reproduce the problem

Visit any package that has Git origin at BitBucket, for example https://www.npmjs.com/package/detergent

Browser with version

n/a

Any error message?

n/a

yentsun commented 6 years ago

Same for GitLab: selection_150

Time has come to fix this!