search

npmStart0 / client

MIT License
3 stars 9 forks source link

Top nav #11

Closed dinilandy closed 3 weeks ago

dinilandy commented 2 months ago
  1. Utilize an array to store page names and corresponding routings dynamically.
  2. Ensure the navigation component supports easy addition and removal of pages without hardcoding.
  3. Utilize Material-UI (MUI) components for the design and styling of the navigation component.
dinilandy commented 2 months ago

Issues #12

dinilandy commented 2 months ago

I wasn't sure if I should create a new CSS style file, so I added the styles directly within the component.

DvoraShechter1 commented 2 months ago

Code looks good! Some minor comments:

  1. In the file src/components/Nav.jsx - Delete the empty line in the array (11) Use the appropriate MUI component for the image and not the img tag, that way you won't need internal styling.
  2. Changes to the package-lock file should be undone.
  3. A link to the issue should be in the description and not in a separate comment.

good luck!

dinilandy commented 2 months ago

I made the changes.

DvoraShechter1 commented 2 months ago

The changes look perfect! Pay attention to points 2 and 3 in the previous comment.

dinilandy commented 2 months ago

I saw this . Thanks