search

npnicholson / flightaware-tracklog

Convert a flight track from Flightaware to a G1000 csv file which can be imported into Foreflight as a tracklog
MIT License
6 stars 1 forks source link

Generates logs with incorrect times > 24:00 #2

Closed joshproehl closed 3 months ago

joshproehl commented 3 months ago

On sever occasions I've generated a log which results in an output file with a filename and dates in the file that are after 2400 hours.

For example:

https://www.flightaware.com/live/flight/N2112G/history/20240807/0017Z/KDTO/KDTO Results in fliename: N2112G-2024-08-07-24:17.csv With the first line of the file:

2024-08-07, 24:17:35,  -00:00,       ,33.19643     ,-97.20115    ,        ,      ,     817,      ,       ,     77,        ,      0,      0,       ,        ,     ,      ,      ,       ,       ,         ,         ,        ,        ,       ,       ,        ,        ,        ,        ,        ,        ,        ,        ,        ,    ,     ,    184

This file can not be imported by Foreflight and results in an error if you try.

Manually fixing the file to change the Lcl Date to 2024-08-08 and Lcl Time (hours) to 00 instead of 24 results in a file that imports into Foreflight correctly. (I have not inspected the code yet to see if this is the correct solution, I'm just guessing.)

npnicholson commented 3 months ago

Thanks for pointing this out. I've fixed the issue so the date should be listed as 2024-08-07-00:17 now as intended.

joshproehl commented 3 months ago

Thanks for the quick response on these! (And for the tool! Makes me so happy to actually be able to grab tracks for my log on flights I wasn't otherwise able to capture!)

The resulting file now parses correctly in Foreflight, however I'll pedantic here and say that it's still not technically correct/fixed. The hour is now correct, but it doesn't increase the date when it rolls over from 2359 to 00:00.

For example, the above linked flight is at 19:17 on 08-07 US Central time, which should be 00:17 on 08-08 UTC, (see: https://time.is/compare/0717PM_6_Aug_2024_in_CT/UTC) however both the generated filename and the file contents use the date 08-07 after this latest patch.

npnicholson commented 3 months ago

I used this tool extensively myself until very recently! I'm glad it's been useful to you as well.

As for the issue, I am fairly certain that the date is correct in this case. The flight in question occurred on August 6th at 19:17CDT according to FlightAware. 08/06/2024 19:17 + 05:00 to UTC is 08/07/2024 00:17. Additionally as a sanity check, the FlightAware link includes the date and time in UTC in the url (20240807/0017Z), so the tool agrees with FlightAware at least. Maybe FlightAware got the date wrong on this particular flight?

I can look into adding an option to manually specify the date/time for the output file name. Manually setting the date/time for the rows in the output CSV will be a bit harder because the tool will need to translate the times it receives from FlightAware.

joshproehl commented 3 months ago

You're right, that's entirely my fault, I had too many Flightaware tabs open at once. :grimacing: Sorry for wasting your time with that, tool confirmed to be working great!