npo6ka / FNEI

Factorio NEI
https://mods.factorio.com/mods/npo6ka/FNEI
36 stars 21 forks source link

GUI lag while Improved Research Queue is installed #66

Closed dbeckwith closed 7 months ago

dbeckwith commented 3 years ago

Some users of my mod Improved Research Queue have noticed that when both mods are enabled, FNEI lags quite a bit when doing anything in the GUI. Any idea why that might be? My mod doesn't add any item prototypes or anything like that, it's just a GUI for the research queue. Maybe something GUI-related your mod is doing when you click something? Maybe gui_iterate is iterating through my mod's GUI somehow?

npo6ka commented 3 years ago

Is this problem still relevant?

Curry commented 3 years ago

I believe so, I am currently getting the same performance issue with Improved Research Queue and FNEI enabled. FNEI v0.4.1 sonaxaton-research-queue v0.4.21

As mentioned, clicking/interacting with anything in the FNEI GUI causes mini-lag spikes. Disabling Improved Research Queue does fix the issue.

IIInitiationnn commented 2 years ago

Can confirm this is still an issue.

npo6ka commented 7 months ago

Many GUIs have been created. FNEI searches all GUI elements to find the required components. A check has been added to ensure that the search occurs only in fnei gui and the problem is fixed. 17899f098a18c0165a5019de5bd7e536c9b6d35c