search

npomfret / react-native-image-tools

Image editing software powered by Abode Creative SDK for iOS and Android.
171 stars 41 forks source link

Option to edit output photo name #7

Open edencakir opened 7 years ago

edencakir commented 7 years ago

Saved photos are always saved with a prefix 'rnimagetools', is there a way to avoid that?

srameshr commented 7 years ago

@edencakir Are you able to save the images? For me, as soon as I click the done button the app crashes on IOS. Could you share me your implementation?

edencakir commented 7 years ago

Ive only implemented for Android.

edencakir commented 7 years ago

@srameshr can you post the stacktrace of the error?

srameshr commented 7 years ago

@edencakir I fixed it. It was permissions issue. BTW whats the increase in file size when u download the SDK? What will be the file size when you proguard compress it?

edencakir commented 7 years ago

Nope, it's not a concern for my project. SDK is standard and can't do anything about it - unrelated to this repo.

srameshr commented 7 years ago

@edencakir I understand that. I just want to know whats the size the editor sdk adds to ur app.

edencakir commented 7 years ago

APK size is 17 MB, I'm not sure how much of it is from SDK.

npomfret commented 7 years ago

Np plans to pass in an option for naming the photos. it easy enough to change them using rn-fetch-blob. Or submit a PR if you desperately want the feature.

srameshr commented 7 years ago

@npomfret Its not immediate. Passing tools option to the editor will be an awesome addition.