The code that collects up subelements of a story — specifically ->parent and ->byline but potentially others — had a bug that copies a parent NPRMLElement into a Byline array of NPRMLElements because it does not clear the temporary $my_array. This logic was in two places.
There really was no need for a temp var so I just inlined the creation of the array and assigned back to the same var.
The code that collects up subelements of a story — specifically
->parent
and->byline
but potentially others — had a bug that copies a parent NPRMLElement into a Byline array of NPRMLElements because it does not clear the temporary$my_array
. This logic was in two places.There really was no need for a temp var so I just inlined the creation of the array and assigned back to the same var.