Closed mikeschinkel closed 8 years ago
Looks good to me, with the exception of that possibly-not-closed <p>
.
In PHP 5.3, this error still shows:
PHP Notice: Undefined property: stdClass::$url in /vagrant/wp-content/plugins/WP-DS-NPR-API/classes/NPRAPI.php on line 164, referer: http://vagrant.dev/wp-admin/options-general.php?page=ds_npr_api_get_multi_settings
if (empty($this->request->params) && !stristr($this->request->url, 'sort=')){
$this->stories = array_reverse($this->stories);
}
@benlk
PHP Notice: Undefined property: stdClass::$url...
That was outside the scope of my changes. However, https://github.com/nprds/nprapi-wordpress/pull/32/commits/2f35137a6ac6b8eb5037ff52fe2553633d824cbf which is now part of this PR hopefully resolves that issue?
No more errors here!
Anything else needed to merge this?
When using PHP 5.6 or PHP 7.0 and debugging options as follows set on the NPR Story API plugin currently throws errors.
You can see the errors shown in this PDF file; look for the first two errors.