switch to https urls in the DS_NPR_API class

[benlk]

Changes

(edited)

• Replaces all http: URLs in the plugin with https: URLs
• Updates the regular expressions used by DS_NPR_API::load_page_hook to find the story ID
• Updates the NPRML XML namespace declaration to also use an HTTPS URL: https://github.com/npr/nprapi-wordpress/issues/45
• Replaces a few outdated NPR links in docs and readmes with correct ones, where the redirect worked in an obvious fashion:
  • Account signup pages
  • Ari Shapiro's bio

Why

From the update document:

With NPR.org going HTTPS, following update needs to be made in the Story API plugin for querying Story content so NPR stories can be queried by HTTPS and HTTP URLs

For https://github.com/INN/WP-DS-NPR-API/issues/11

[benlk]

A question before merging: do any of these other references to insecure URLs need to be changed?

./classes/NPRAPI.php:  const NPRAPI_PULL_URL = 'http://api.npr.org';
./classes/NPRAPI.php:  const NPRML_NAMESPACE = 'xmlns:nprml=http://api.npr.org/nprml';
./classes/NPRAPIWordpress.php:   *   The path part of the request URL (i.e., http://example.com/PATH).
./ds-npr-api.php:   $def_url = 'http://api.npr.org';
./get_stories.php:                  if ( stristr( $query_string, 'http:' ) ) {
./settings_ui.php:       <div><p>Create an NPR API query (see the <a target="_" href="http://www.npr.org/api/queryGenerator.php">NPR API query generator</a>). Enter your queries into one of the rows below to have stories on that query automatically publish to your site. Please note, you do not need to include your API key to the query.  </div>
./tests/test-ds-npr-api.php:        $this->assertEquals( $option, 'http://api.npr.org' );

[benlk]

• [x] API URLs and associated tests
• [x] NPRML Namespace: https://github.com/npr/nprapi-wordpress/issues/45
• [x] doc comments in PHP files

[milespj]

Hi Ben -

All of NPR's website links (including API calls) are generally now HTTPS. In fact if you find any that aren't HTTPS let me know! So, we should update all of the URL's to be HTTPS to eliminate unnecessary redirects.

[benlk]

Cool, I'll update this pull request with https urls for all the NPR links, where those links can be updated.

Of note:

• the query generator at https://www.npr.org/api/queryGenerator.php still generates http: URLs like http://api.npr.org/query?id=1139&apiKey=demo
• https://info.ds.npr.org/support.html has a certificate error; insecure redirects to nrpsupport.desk.com's front page
• https://digitalservices.npr.org/post/npr-api-content-permissions-control has a certificate error
• the nrpsupport.desk.com links are all dead: https://github.com/npr/nprapi-wordpress/issues/43 This was addressed in https://github.com/npr/nprapi-wordpress/commit/f4032ce35af448a9800f6412884f483ca986819f
• I'm updating the NPRML namespace link: https://github.com/npr/nprapi-wordpress/issues/45

[milespj]

Thanks for all of these documentation edits! Other than the one URL that was still marked as HTTP this looks good.

[benlk]

That must've happened when I merged https://github.com/npr/nprapi-wordpress/commit/f4032ce35af448a9800f6412884f483ca986819f into this branch; my bad. It's fixed now.

[milespj]

Just wanted to mention that I'm good with this pull request!