Revisions to the NPR API editor meta box

[benlk]

Changes

• Removes the "push to NPR One" checkbox from the "Publish" meta box, and moves it to the "NPR Story API" meta box
• Adds checkboxes for "Include for reading on NPR.org" and "Include for listening in NPR One" and "Set as featured story in NPR One" settings. These checkboxes include server-side and browser-side validation, such that the two "Include..." checkboxes are only checked if "Send to NPR API" is checked, and "Set as featured story in NPR One" is only checked if "Include for listening in NPR One" is checked.
  • QUESTION: What's the NPRML parent ID supposed to be for sending a story to NPR.org?
  • including for NPR One sets a NPRML parent ID of 319418027
  • setting as featured in NPR One sets a NPRML parent ID of 500549367
• Adds a field to track the date after which the story should no longer be pushed on NPR One, which defaults to 7 days from the story's publish date.
  • The expiry date is stored in the post meta in ISO 8601 format, but is presented to the article editor using an HTML5 date input (or, if the useragent does not support that, the jQuery-ui datepicker) and an HTML5 time input (which falls back to text input with a placeholder)
  • The expiry date is attached to the NPRML as the tag audioRunByDate with dates formatted like so: 1 Oct 2017 01:00:00 -0400, 29 Feb 2020 23:59:00 -0500
  • Because WordPress does not include styles for jQuery-ui objects, this plugin of necessity includes a version of the jQuery-ui stylesheet and its spritesheet. This shim can be removed when all browsers support input type="date" .
• Adds some comments and formatting fixes, generally by converting spaces to tabs
• Adds a plugin text domain named nprapi

Notes

Tests will fail in PHP 5.3 because Travis-ci.org doesn't ship 5.3 on their default test-running boxes anymore. For updates to the test-running process to cover PHP 7 and 7.1, see https://github.com/npr/nprapi-wordpress/pull/46

HTTPS support changes are in https://github.com/npr/nprapi-wordpress/pull/44

Minor PHP 7 compat fixes are in https://github.com/npr/nprapi-wordpress/pull/42

Questions:

• [x] What's the NPRML parent ID supposed to be for sending a story to NPR.org?
• [ ] What version number should all this new functionality be tagged with? 1.6 was the last release of this plugin; should the docblock comments for these functions say @version 1.7?
• [ ] How does including jQuery-ui's stylesheet and images from https://jqueryui.com/themeroller/ affect the plugin's license? https://jqueryui.com/themeroller/ was used to generate those; the footer of that page references https://jquery.org/license/ which says that all projects referencing it are MIT licensed. The downloaded CSS is MIT licensed according to its header comment.

[jgarlow]

QUESTION: What's the NPRML parent ID supposed to be for sending a story to NPR.org?

Actually the NPR.org code is taking a completely different approach - there will be a new separate API which can be used to mark a story available for syndication. This isn't yet ready to be used at this time.

[jgarlow]

Note that the SOW just says to replace the current functionality that says "Push to NPR" to say "Send to the NPR API" - you don't have to make any other changes there. This does not require you to say anything about NPR.org.

[jgarlow]

I don't know enough about this code to do a full review of it but I left some comments that I hope are helpful

[benlk]

Yes, those were helpful comments. Does my response to the checked() question make sense?

[benlk]

Merging with approval from Olubunmi Odumade via email.