search

npr / nprapi-wordpress

Access the NPR API from within WordPress. This repository is no longer being maintained. See the README for more information.
GNU General Public License v2.0
13 stars 30 forks source link

Set post author if user exists in Wordpress #6

Closed JeremyDunn closed 9 years ago

JeremyDunn commented 10 years ago

Sets the post author when ingesting story if user exists in system (by nickname).

CrookedNumber commented 9 years ago

Thanks for the PR!

One question: the changes are inside a pull function, but the PR description references "ingesting" (a/k/a/ - pushing) a story. Just a typo?

JeremyDunn commented 9 years ago

By ingesting I just mean it's taking in (pulling) the story from the API into Wordpress.

CrookedNumber commented 9 years ago

Gotcha. FWIW, "ingest" is the term that NPR uses internally (and, to a lesser degree, externally) to describe pushing content to the API, even though there are much better words we could use; push, for example.

Hence the confusion.

CrookedNumber commented 9 years ago

OK. Looks good, though I'm leery of merging it as-is, since it contains PHP short-array syntax. Adding those few line would automatically mean that the plugin would PHP 5.4+.

I can make the change manually, unless you want to do it and keep the whole process in this PR.

JeremyDunn commented 9 years ago

I've amended my commit to use the older array syntax.

CrookedNumber commented 9 years ago

Hmmm ... I still see the sam syntax in https://github.com/npr/WP-DS-NPR-API/pull/6/files

JeremyDunn commented 9 years ago

So sorry, I replaced one array and not the other.

CrookedNumber commented 9 years ago

Thanks very much for the contribution. Most appreciated!