Binding to fullscreen events on iOS breaks the app

nprapps / bestsongs14

Songs We Love 2014

http://apps.npr.org/best-songs-2014/

MIT License

13 stars 2 forks source link

Closed dannydb closed 9 years ago

dannydb commented 9 years ago

iOS doesn’t like line 101 in app.js: $(document).on(screenfull.raw.fullscreenchange, onFullscreenChange); https://github.com/nprapps/bestsongs14/blob/master/www/js/app.js#L101

TylerFisher commented 9 years ago

You can't fullscreen on mobile anyway, so let's just not attach the event handler on mobile.

onyxfish commented 9 years ago

Can we just do something like:

if (hasOwnProperty(screenfull.raw, 'fullscreenchange') {
   ... bind ...
}

TylerFisher commented 9 years ago

Nope.