search

nprapps / elections24-primaries

2024 primary/caucus election results
https://apps.npr.org/primary-election-results-2024/
Other
5 stars 1 forks source link

`county-detail`: Winner logic should rely on EEVP #161

Closed alykat closed 7 months ago

alykat commented 7 months ago

Spun off from https://github.com/nprapps/elections24-primaries/issues/160

Example county: Rawlins County, KS, in the Democratic presidential primary:

image

We're displaying a winner checkmark based on reportingPercentage (100%), but since we have EEVP (90%), we should be going based on that. (And no winner checkmark would appear in this case.) It's referenced here in the county-detail code:

https://github.com/nprapps/elections24-primaries/blob/main/src/js/components/county-detail/index.js#L116-L124

Please double-check other references to reportingPercentage vs. EEVP while you're looking at the component.