search

nprapps / elections24-primaries

2024 primary/caucus election results
https://apps.npr.org/primary-election-results-2024/
Other
5 stars 1 forks source link

Rhode Island county maps not shading in #162

Closed alykat closed 5 months ago

alykat commented 5 months ago

For Rhode Island (Dem and GOP), we have county-level results, but the map’s not coloring in. https://apps.npr.org/primary-election-results-2024/states/RI.html#date=4%2F2%2F2024&office=P&party=Dem&counties=true&state https://apps.npr.org/primary-election-results-2024/states/RI.html#date=4%2F2%2F2024&office=P&party=GOP&counties=true&state

Results appear in the tooltip, however, and I can click a county to show the results table:

image

Seeing this error in console:

image

And there is an "undefined" county in the dropdown:

image
abidishajia commented 5 months ago

@hilaryfung and I paired on this ticket.

  1. We aren't able to click on the dropdown on localhost.
  2. On prod, it's kind of random. I was able to select from the dropdown for republican, but after reloading, both of the dropdowns don't work. They don't work for Hilary either.
  3. Fips seem to be different. The one from AP starts from 40 and if we inspect the county map svg id start from 44.
alykat commented 5 months ago

done in https://github.com/nprapps/elections24-primaries/commit/65fe7455f55181ea98fabeadd456f9bce2f07305