search

nprapps / liveblog-standalone

NPR's liveblog rig 2.0
Other
6 stars 1 forks source link

Test loader script #13

Closed thomaswilburn closed 4 years ago

thomaswilburn commented 4 years ago

Initial tests seem to indicate that the <side-chain> custom element gets stripped by CorePub, so we may need to switch to a Pym embed, but I'd like to make sure there's no workaround first. We can still send Sidechain messages for simplicity's sake.

thomaswilburn commented 4 years ago

TODO: Also, add mutation observers to the existing loader so that it can work around the fact that we're shimming Sidechain embeds into the page through <p> tags. We have to do that to get to CorePub sites, but it means we no longer get the PJAX-friendly benefit of automounting custom elements, so we need to watch the page for new wrapper elements and upgrade them when they appear.