nprapps / liveblog-standalone

NPR's liveblog rig 2.0
Other
6 stars 1 forks source link

Links can't open in new tabs #56

Open thomaswilburn opened 4 years ago

thomaswilburn commented 4 years ago

If we set the base in the head, we break internal links. However, if we don't, people complain that this page doesn't act like most NPR pages, in that links open in the current tab.

There are strong accessibility reasons not to automatically open links in a new tab, and I would argue that because the player here isn't on a PJAX page, we don't need to abide by the same expectations as the rest of the site. But we will need to have that discussion, and if I'm overruled, add JS to detect in-page links and scroll/replace the URL fragment.