Creating fields sometimes removes all fields from category records.

[tylerhasman]

I've had it happen a few times while working where I'll create a new field and one of my category records will become totally blank. This ends up deleting all the data in the children records because they all inherit the category's fields. I'm not sure the exact steps to reproduce this because it seems to happen sometimes and not others. Luckily I've been using version control so when this happens I just revert but it's a little frustrating.

Not sure if this is related but, when I duplicated a child record and renamed it, it removed the parents fields completely.

I've managed to create some data where the bug is reproducible, if you'd like I can share it. When I edit the name of one record, an entirely unrelated record will have all its fields removed.

[tylerhasman]

I think this is related to #186

[tylerhasman]

I've forked this repo and done some detective work, the issue seems to be caused by sorting of the record tree.

Specifically this part in recordscontroller.cpp

    bool needsSorting = oldDisplayName != displayName;

    if (needsSorting)
    {
        for (RecordSetList::iterator it = this->model->begin();
             it != this->model->end();
             ++it)
        {
            std::sort((*it).records.begin(), (*it).records.end(), recordLessThanDisplayName);
        }
    }

[tylerhasman]

Ok it looks like it has something to do with how things are being sorted for sure. Picking diffierent names for the new record causes different records to be altered as a side-effect.

[tylerhasman]

Ok I've found the issue.

setRecordDisplayName(newId, newDisplayName);

causes the record list to be changed which in turn causes

Record* record = this->getRecordById(newId);

in RecordsController::updateRecord to now point to the wrong record. This should be a simple fix now.

[tylerhasman]

Fixed in #196