search

npryce / adr-tools

Command-line tools for working with Architecture Decision Records
Other
4.56k stars 578 forks source link

adr-tools doesn't work correctly in git bash because `more` is missing #68

Closed andrew-schofield closed 5 years ago

andrew-schofield commented 6 years ago

The linux toolset included with git bash is missing more which means that adr help (f.e.) doesn't work. git bash does have less which works just as well, so my initial workaround was to copy less.exe to more.exe in the git bash usr/bin/ folder.

Is there a technical reason why adr-tools uses more rather than less? Could it be changed without breaking other platforms?

I can submit a PR with an updated INSTALL.md which includes a note about copying less to more, or I can submit a PR with the shell script change to use less instead of more.

retnuh commented 6 years ago

Ideally adr should use $PAGER if it’s set; then check for more and/or less as a fallback. On Fri 14 Sep 2018 at 10:23, Andrew Schofield notifications@github.com wrote:

The linux toolset included with git bash is missing more which means that adr help (f.e.) doesn't work. git bash does have less which works just as well, so my initial workaround was to copy less.exe to more.exe in the git bash usr/bin/ folder.

Is there a technical reason why adr-tools uses more rather than less? Could it be changed without breaking other platforms?

I can submit a PR with an updated INSTALL.md which includes a note about copying less to more, or I can submit a PR with the shell script change to use less instead of more.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/npryce/adr-tools/issues/68, or mute the thread https://github.com/notifications/unsubscribe-auth/AARND2JWWUiWG0PBh41p5RSc-H3q-EATks5ua3WvgaJpZM4Wo69u .

npryce commented 5 years ago

Adr-tools does use $PAGER. It also uses $ADR_PAGER if (for some reason) you want a different pager for adr-tools than your default. It falls back to more because that is defined by POSIX, and less is not. If you want to use less, set either PAGER or ADR_PAGER to less.

andrew-schofield commented 5 years ago

In that case the install instructions for git bash do need updating, as it neither defines $PAGER nor has the POSIX compliant more

npryce commented 5 years ago

Yes. See #69 (contributions welcome)