Route snapper is picking up irrelevant edges

nptscot / editor

https://nptscot.github.io/editor/

Apache License 2.0

0 stars 0 forks source link

Route snapper is picking up irrelevant edges #19

Open dabreegster opened 1 week ago

dabreegster commented 1 week ago

Footways and things are currently included. Need to do the graph refactor to have a customizable mode, and use it here

dabreegster commented 1 day ago

95982c2e4fe64e6369e8df21ab5a80be3839f86b started this. But there's more work to do to initially clean up the graph of possibly editable roads:

[ ] Edinburgh has lots of pedestrian crossings tagged just as highway=footway, like https://www.openstreetmap.org/way/400692851. Ideally we'd prune.
[ ] Need to prune out disconnected components, like highway=path in a golf course, https://www.openstreetmap.org/way/909112247

Robinlovelace commented 1 day ago

In case of use/interest, we remove irrelevant ways with the the get_cycling_network() function early in the process.

Function documentation: https://nptscot.github.io/osmactive/reference/get_cycling_network.html
Regex for highway values we exclude:

    "abandoned|bridleway|bus_guideway|byway|construction|corridor|disused|elevator|emergency|escalator|escap",
    "|far|fixme|gallop|historic|motorway|no|planned|platform|proposed|raceway|rest|road|services|steps|track"

Source: https://github.com/nptscot/osmactive/blob/e7372dee246af427781e35e863d40cdbbdefe405/R/osmactive.R#L50C1-L52C1

Bicycle values we exclude:

    "mtb|discouraged|unknown|no"

Robinlovelace commented 1 day ago

It could be beneficial to align these and I think the function is imperfect, so any issues with the outputs let us know. You can see the results here: https://nptscot.github.io/#/clos/#11.15/55.939/-3.2132

Robinlovelace commented 1 day ago

Or ideas for improvement..

dabreegster commented 1 day ago

Thanks, I was referring to that filtering. It'll be something to iterate on. For NPW, we're not just trying to reason about existing infrastructure, but also let people quickly select roads to consider improvements. If we filter out too much, then somebody has to draw freehand. What if there's a very poor surface track and someone's proposal is to pave it and make a proper rural shared use path?

Robinlovelace commented 21 hours ago

What if there's a very poor surface track and someone's proposal is to pave it and make a proper rural shared use path?

Oh yes, so there are different filtering requirements for the 'currently cyclable network' data that osmactive gets and the 'potentially cyclable network after interventions' network.