search

nptscot / networkmerge

Merge geographic route networks
https://nptscot.github.io/networkmerge/
MIT License
9 stars 3 forks source link

Test for road network in Leeds #101

Open Robinlovelace opened 8 months ago

Robinlovelace commented 8 months ago

Heads-up @anisotropi4 I'm hitting an issue testing the code on a larger dataset.

Dataset: https://raw.githubusercontent.com/nptscot/coherentnet/main/data/osm_leeds.geojson

Error message:

! shapely.errors.GEOSException: TopologyException: Ring edge missing at 425022.90000000002 435124.70000000001

Reproducible code: https://github.com/nptscot/networkmerge/blob/101-test-for-road-network-in-leeds/tests/leeds.qmd

anisotropi4 commented 8 months ago

@Robinlovelace I'm not sure what to do here as I can't find the code nor data in the repository. I've just git pull and it doesn't seem to be there in the repository networkmerge. I also don't seem to be able to find coherentnet.

anisotropi4 commented 8 months ago

@Robinlovelace I've got a fix this. How do you want me to patch this as I had to download the code separately?

Robinlovelace commented 8 months ago

Can you add it to this script? https://github.com/nptscot/networkmerge/blob/main/tests/leeds.qmd

Ideal would be to re-write the code to import a module to avoid defining the functions and simply use the updated version of the module, starting with

import networkmerge

but happy with whatever works.

Robinlovelace commented 8 months ago

Ideally as a PR rather than pushing to main but again that's optional.