search

nptscot / npt

Data processing code, also use this repo for issue tracking for the Network Planning Tool. See https://nptscot.github.io for development version
https://www.npt.scot/
GNU Affero General Public License v3.0
5 stars 0 forks source link

Total number of shopping trips is inconsistent between scenarios #369

Closed joeytalbot closed 6 months ago

joeytalbot commented 9 months ago

This is probably due to the way in which we halved the cycle mode share for shopping.

See https://github.com/nptscot/npt/issues/367 and https://github.com/nptscot/npt/issues/355

Robinlovelace commented 8 months ago

Question for @joeytalbot and @mem48 how do we verify if this is fixed? @wangzhao0217 has completed a new build so let's check in the output files.

mem48 commented 8 months ago

Should be able to check the zone stats directly

Robinlovelace commented 8 months ago

Can you take a look at the zone stats @wangzhao0217 ? Malcolm can provide pointers on that.

joeytalbot commented 8 months ago

I think this is fixed in the latest PR #384 but some more checks would be useful

Robinlovelace commented 8 months ago

OK let's close after the fix is live on www.npt.scot. Can you re-run tar_make() on the latest version of main @wangzhao0217 and create a new release?

joeytalbot commented 6 months ago

Can we close this now?

Robinlovelace commented 6 months ago

Happy to close. It's not fixed on the main website but that will happen soon, after the latest full build by @wangzhao0217 is deployed.