search

nptscot / npt

Data processing code, also use this repo for issue tracking for the Network Planning Tool. See https://nptscot.github.io for development version
https://www.npt.scot/
GNU Affero General Public License v3.0
5 stars 0 forks source link

Gradients are still not right #373

Closed joeytalbot closed 6 months ago

joeytalbot commented 6 months ago

Although @si-the-pie showed us a CycleStreets fix for Waverley Bridge in May last year (https://github.com/nptscot/npt/issues/92#issuecomment-1564525607), it is still given a 9% gradient on nptscot.github.io. You can see from this screenshot that North Bridge over Waverley Station also has a surprisingly high gradient.

waverley bridge

Also, a section of the Roseburn Path is still being given a 9% gradient although it's actually a flat railway path: roseburn

Robinlovelace commented 6 months ago

I'm going to close this for now as it's not something we can fix by changing code in this repo, unless we start post-processing the gradients from CycleStreets. I think an upstream fix is needed. Thoughts on that @mvl22 and @si-the-pie? Happy to re-open the issue in another repo although I imagine you'll track it in your internal systems, right?

Great work Joey on the clear diagnosis of the issue, closing not because it's not an issue (clearly it is) but to focus on the code in this repo. Happy to re-open if that would be useful or if anyone thinks of a quick fix on the R side.

joeytalbot commented 6 months ago

I don't think it's a good idea to close this so rapidly. Do we even know whether the problem is with CycleStreets or with our own use of OSM data?

Robinlovelace commented 6 months ago

It's a possibility that it's an issue with our code causing the gradient issue, but seems unlikely. Have you checked the route on the https://www.cyclestreets.net/ website? That could give some insight.

Robinlovelace commented 6 months ago

Happy to keep it open for now and close if we can confirm it's an issue upstream.

joeytalbot commented 6 months ago

Looking at the CycleStreets route profiles (even the improved Waverley Bridge one), I think this is a CycleStreets issue after all.

Waverley Bridge: waverley profile

North Bridge: north bridge profile

Roseburn Path: roseburn profile

joeytalbot commented 6 months ago

I'm happy to close this.

mem48 commented 2 months ago

Old Issue, but flagging that my 2m DTM is now live on https://placebasedcarboncalculator.github.io/pbcc/#/#17.32/55.952256/-3.188168. Currently a 3GB pmtiles down to zoom level 13, but planning to go to zoom 14.

NPT - 50m

image

PBCC - 2m

image

Robinlovelace commented 2 months ago

Great to see, thanks for flagging Malcolm.