search

nptscot / npt

Data processing code, also use this repo for issue tracking for the Network Planning Tool. See https://nptscot.github.io for development version
https://www.npt.scot/
GNU Affero General Public License v3.0
5 stars 0 forks source link

rnet outputs capitalised variables inconsistently #395

Closed mvl22 closed 8 months ago

mvl22 commented 8 months ago

The rnet dataset has two fields that, unlike all others, are capitalised: 'Quietness' and 'Gradient'.

This means that the website codebase has various places where this has to have special-case code to swap from lower-case to upper-case:

      'quietness': [
        "step", ["get", "Quietness"],

making it harder to convert various datastructures to be self-referencing or auto-created.

Can these be fixed up?

Robinlovelace commented 8 months ago

Can these be fixed up?

Sure thing happy to fix this one. All lowercase in next data release.

Robinlovelace commented 8 months ago

@wangzhao0217 can you take a look at this when you get a chance?

wangzhao0217 commented 8 months ago

@Robinlovelace I directly pushed a fix to the main branch for an issue in 'rnet_functions.R', instead of using a new branch and a pull request. Sorry about that. I'll make sure to follow the correct process next time. Another question: Should I apply the fix across the entire NPT ?

Robinlovelace commented 8 months ago

Another question: Should I apply the fix across the entire NPT ?

Yes but do it as a Pull Request rather than pushing directly to the main branch :+1:

wangzhao0217 commented 8 months ago

solved in the latest push

Robinlovelace commented 8 months ago

Great job Zhao :fire: