search

nptscot / npt

Data processing code, also use this repo for issue tracking for the Network Planning Tool. See https://nptscot.github.io for development version
https://www.npt.scot/
GNU Affero General Public License v3.0
5 stars 0 forks source link

Reduce max route distance #401

Closed joeytalbot closed 5 months ago

joeytalbot commented 5 months ago

Currently the max route distance is 30km. This seems unnecessarily long for cycle trips.

For utility trips, the euclidean distance of the jittered desire lines has been limited to 5km, but we still have a few routes that reach close to 30km route distance, e.g. where they cross the Firth of Forth.

joeytalbot commented 5 months ago

Euclidean distances of utility trips (in geo_subset) euclidean-hist

joeytalbot commented 5 months ago

Route distances of utility trips (in geo_subset) distances-hist

joeytalbot commented 5 months ago

What do you think would be sensible for max route distance? 10km or 20km?

joeytalbot commented 5 months ago

We should also clearly state in the methods that the maximum desire line distance differs between commute/school and other everyday trips (or change this)

Robinlovelace commented 5 months ago

Agreed, quick fix Joey?

joeytalbot commented 5 months ago

This is done in #406

Robinlovelace commented 5 months ago

Good stuff. Pro tip @joeytalbot: you can close issues via commits with messages containing close #issuenumber e.g.:

git commit -am 'Set max route distance, close #401'

would close this issue when the PR it's part of is merged.