search

nptscot / npt

Data processing code, also use this repo for issue tracking for the Network Planning Tool. See https://nptscot.github.io for development version
https://www.npt.scot/
GNU Affero General Public License v3.0
5 stars 0 forks source link

Bug in SI model #403

Closed mem48 closed 4 months ago

mem48 commented 5 months ago

@joeytalbot a heads up I think I've found a bug in simodels https://github.com/Robinlovelace/simodels/issues/31 that may affect the NPT work.

In short simodels::si_calculate is returning two new variables interaction and output_col. When it should only return one interaction it seems like output_col contains the actual results, so you may want to check this.

Robinlovelace commented 5 months ago

Fixed upstream: https://github.com/Robinlovelace/simodels/pull/32

@joeytalbot that could account for the totals suddenly not adding up in CRUSE.

Can you upgrade you package version and test? I'll try to release a new version.

joeytalbot commented 5 months ago

Ok I've installed the latest package version. Which is the correct output variable now, output_col or interaction?

joeytalbot commented 5 months ago

The trip numbers seem to be consistent between scenarios.

Robinlovelace commented 5 months ago

Ok I've installed the latest package version. Which is the correct output variable now, output_col or interaction?

interaction is the correct one in the latest version. There shouldn't be an output_col produced by the latest version of this package, are you sure you've tested on the latest version of the package Joey?

Robinlovelace commented 4 months ago

This is now fixed.