search

nptscot / npt

Data processing code, also use this repo for issue tracking for the Network Planning Tool. See https://nptscot.github.io for development version
https://www.npt.scot/
GNU Affero General Public License v3.0
5 stars 0 forks source link

Cycle segregation code returns parking spaces #441

Closed Robinlovelace closed 2 months ago

Robinlovelace commented 2 months ago

Following #436, it seems that some of the results generated by cycling-by-design-tests.qmd include parking spaces and other bits of the network that are not cycled on.

We should look at this and fix the issue.

It seems that the oe_get_network() function does not return all parts of the transport network, for example missing parts of The Headrow in Leeds (heads-up @agila5 on that and let us know if you'd like us to open an issue in osmextract with a reprex), so I've switched to using the function oe_get() which does not have those filters, there's like things we can learn from this: https://github.com/ropensci/osmextract/blob/master/R/get-network.R

Illustration from here.

image

agila5 commented 2 months ago

Hi everyone and good morning!

heads-up @agila5 on that and let us know if you'd like us to open an issue in osmextract with a reprex

Yes, please, so I can keep track of the issue.

Robinlovelace commented 2 months ago

Will do, thanks Andrea. This issue is now fixed upstream so closing: https://github.com/nptscot/osmactive